-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify epred #323
Simplify epred #323
Conversation
Hmm interesting. The with approch is directly based on the |
Yeah not sure, I guess just look at |
I'll go in and look at this. |
> str(prep$dpars)
List of 2
$ mu :List of 10
..$ family:List of 16
.. ..$ family : chr "custom"
.. ..$ link : chr "identity"
.. ..$ name : chr "latent_lognormal"
.. ..$ dpars : chr [1:2] "mu" "sigma"
.. ..$ lb :List of 2
.. .. ..$ mu : chr NA
.. .. ..$ sigma: chr "0"
.. ..$ ub :List of 2
.. .. ..$ mu : chr NA
.. .. ..$ sigma: chr NA
.. ..$ type : chr "real"
.. ..$ vars : chr [1:3] "pwindow" "swindow" "vreal1"
.. ..$ loop : logi FALSE
.. ..$ specials : chr(0)
.. ..$ log_lik : NULL
.. ..$ posterior_predict: NULL
.. ..$ posterior_epred : NULL
.. ..$ env :<environment: 0x12f030b38>
.. ..$ normalized : chr ""
.. ..$ link_sigma : chr "log"
.. ..- attr(*, "class")= chr [1:3] "customfamily" "brmsfamily" "family"
..$ ndraws: int 4000
..$ nobs : int 500
..$ fe :List of 2
.. ..$ X: num [1:500, 1] 1 1 1 1 1 1 1 1 1 1 ...
.. .. ..- attr(*, "dimnames")=List of 2
.. .. .. ..$ : chr [1:500] "1" "2" "3" "4" ...
.. .. .. ..$ : chr "Intercept"
.. .. ..- attr(*, "assign")= int 0
.. ..$ b: num [1:4000, 1] 1.75 1.77 1.73 1.76 1.76 ...
.. .. ..- attr(*, "dimnames")=List of 2
.. .. .. ..$ draw : chr [1:4000] "1" "2" "3" "4" ...
.. .. .. ..$ variable: chr "b_Intercept"
.. .. ..- attr(*, "nchains")= int 4
..$ sp : list()
..$ cs : list()
..$ sm : list()
..$ gp : list()
..$ re : list()
..$ ac : list()
..- attr(*, "class")= chr "bprepl"
$ sigma: num [1:4000] 0.498 0.502 0.486 0.469 0.488 ... |
I think because it's a custom family it's more complicated, so reverting back to the |
Oh thats very interesting. Good detective work |
* simplify epred * Revert latent_lognormal epred --------- Co-authored-by: athowes <[email protected]> Former-commit-id: 7ae25e866f8deb44b8cf00a61569a6cc9816a382 [formerly 30c10c00ab5ecaa749759b98722d83ce15cded1c] Former-commit-id: c002105d1c1de4feeee5af7bd2e3b0d67b7502b4
This PR is unlinked to an issue. In reviewing the current functionality needed for a family I slightly simplified the current code.
Unrelated to this PR there are lots of ways we can streamline adding families and sharing support across models and across families (for models) it looks like which is great.